Worst icons ever? My reflexive answer: the icons for the buttons that open and close elevator doors. At least, the ones in my building.
I’ve seen then hundreds of times. Yet, every time I actually need to use them — usually, to help out someone enter by opening the closing doors — it takes me so long to work out which button does what that the effort invariably fails.